[VAULTS] Simplify beacon chain deposit processing #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
failingtwice
force-pushed
the
deposit-logistics
branch
from
a54716a to
cfef66c
Compare
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: b12a322 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
tamtamchik
reviewed
Jan 17, 2025
| @@ -0,0 +1,16 @@ | |||
| // SPDX-FileCopyrightText: 2024 Lido <[email protected]> | |||
There was a problem hiding this comment.
Suggested change
| // SPDX-FileCopyrightText: 2024 Lido <[email protected]> | |
| // SPDX-FileCopyrightText: 2025 Lido <[email protected]> |
|
|
||
| _makeBeaconChainDeposits32ETH(_numberOfDeposits, bytes.concat(withdrawalCredentials()), _pubkeys, _signatures); | ||
| emit DepositedToBeaconChain(msg.sender, _numberOfDeposits, _numberOfDeposits * 32 ether); | ||
| emit DepositedToBeaconChain(msg.sender, numberOfDeposits); |
There was a problem hiding this comment.
Wouldn't a total deposited amount be needed for analytics?
There was a problem hiding this comment.
I've decided not to include the total amount because each individual amount is included in the DepositContract's DepositEvent
There was a problem hiding this comment.
I'm not an expert, but wouldn't it be more convenient for analytics / UI to receive it as only one event instead of many? Just from this angle.
| @@ -460,3 +475,27 @@ describe("Scenario: Staking Vaults Happy Path", () => { | |||
| expect(await stakingVault.locked()).to.equal(0); | |||
| }); | |||
| }); | |||
|
|
|||
| function getRoot(creds: string, pubkey: string, signature: string, size: bigint) { | |||
tamtamchik
reviewed
Jan 17, 2025
failingtwice
force-pushed
the
deposit-logistics
branch
from
42fd97b to
71e93b2
Compare
tamtamchik
reviewed
Jan 22, 2025
| bytes32 sigSlice2Root = sha256(abi.encodePacked(_signature[64:], bytes32(0))); | ||
| bytes32 signatureRoot = sha256(abi.encodePacked(sigSlice1Root, sigSlice2Root)); | ||
|
|
||
| // Step 5. Compute the root-toot-toorootoo of the deposit data |
There was a problem hiding this comment.
Suggested change
| // Step 5. Compute the root-toot-toorootoo of the deposit data | |
| // Step 5. Compute the root-toot-totoro of the deposit data |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets rid of intense gas optimization for deposits in favor of simplicity and readability thanks to the Pectra's MAX_EB increase.